pkg/rules/rulespb.AlertState: marshal JSON as lowercase

Currently, alert state is rendered as upper case. In Prometheus it is lower case. This fixes it. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
thanos-io · Jul 2, 2020 · 4013d66 · 4013d66
1 parent 482d0f2
commit 4013d66
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/rules/rulespb/custom.go b/pkg/rules/rulespb/custom.go
@@ -247,7 +247,7 @@ func (x *AlertState) UnmarshalJSON(entry []byte) error {
 }
 
 func (x *AlertState) MarshalJSON() ([]byte, error) {
-	return []byte(strconv.Quote(x.String())), nil
+	return []byte(strconv.Quote(strings.ToLower(x.String()))), nil
 }
 
 // Compare compares alert state x and y and returns:

diff --git a/pkg/rules/rulespb/custom_test.go b/pkg/rules/rulespb/custom_test.go
@@ -207,23 +207,23 @@ func TestJSONUnmarshalMarshal(t *testing.T) {
 										Annotations: labels.Labels{
 											{Name: "annotation1", Value: "2"},
 										},
-										State:                   "INACTIVE",
+										State:                   "inactive",
 										ActiveAt:                nil,
 										Value:                   "1",
 										PartialResponseStrategy: "WARN",
 									},
 									{
 										Labels:                  nil,
 										Annotations:             nil,
-										State:                   "FIRING",
+										State:                   "firing",
 										ActiveAt:                &twoHoursAgo,
 										Value:                   "2143",
 										PartialResponseStrategy: "ABORT",
 									},
 								},
 								LastError:      "1",
 								Duration:       60,
-								State:          "PENDING",
+								State:          "pending",
 								LastEvaluation: now.Add(-1 * time.Minute),
 								EvaluationTime: 1.1,
 							},