Skip to content

Commit

Permalink
Apply suggestions from PR review
Browse files Browse the repository at this point in the history
Signed-off-by: Max Neverov <neverov.max@gmail.com>

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
  • Loading branch information
mneverov and bwplotka committed Aug 7, 2020
1 parent ad53a26 commit 4f0a170
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -34,7 +34,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#2892](https://github.com/thanos-io/thanos/pull/2892) Receive: Receiver fails when the initial upload fails.
- [#2865](https://github.com/thanos-io/thanos/pull/2865) ui: Migrate Thanos Ruler UI to React
- [#2964](https://github.com/thanos-io/thanos/pull/2964) Query: Add time range parameters to label APIs. Add `start` and `end` fields to Store API `LabelNamesRequest` and `LabelValuesRequest`.
- [#2996](https://github.com/thanos-io/thanos/pull/2996) Sidecar: Add `reloader_config_errors_total` metric. Add new flags `--reloader.watch-interval`, and `--reloader.retry-interval`.
- [#2996](https://github.com/thanos-io/thanos/pull/2996) Sidecar: Add `reloader_config_apply_errors_total` metric. Add new flags `--reloader.watch-interval`, and `--reloader.retry-interval`.

### Changed

Expand Down
4 changes: 2 additions & 2 deletions pkg/reloader/reloader.go
Expand Up @@ -151,8 +151,8 @@ func New(logger log.Logger, reg prometheus.Registerer, o *Options) *Reloader {
),
configErrors: promauto.With(reg).NewCounter(
prometheus.CounterOpts{
Name: "reloader_config_errors_total",
Help: "Total number of config reads that failed.",
Name: "reloader_config_apply_errors_total",
Help: "Total number of config applies that failed.",
},
),
watches: promauto.With(reg).NewGauge(
Expand Down

0 comments on commit 4f0a170

Please sign in to comment.