Skip to content

Commit

Permalink
Merge branch 'main' into mhoffm-fix-postings-reader
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaHoffmann committed Aug 31, 2023
2 parents c9642bc + e0126c7 commit 5fe9ddc
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions pkg/store/bucket.go
Expand Up @@ -1364,15 +1364,18 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, seriesSrv storepb.Store
"block.resolution": blk.meta.Thanos.Downsample.Resolution,
})

if err := blockClient.ExpandPostings(sortedBlockMatchers, seriesLimiter); err != nil {
span.Finish()
return errors.Wrapf(err, "fetch series for block %s", blk.meta.ULID)
}
onClose := func() {
mtx.Lock()
stats = blockClient.MergeStats(stats)
mtx.Unlock()
}

if err := blockClient.ExpandPostings(sortedBlockMatchers, seriesLimiter); err != nil {
onClose()
span.Finish()
return errors.Wrapf(err, "fetch postings for block %s", blk.meta.ULID)
}

part := newLazyRespSet(
srv.Context(),
span,
Expand Down Expand Up @@ -3525,6 +3528,7 @@ type queryStats struct {
func (s queryStats) merge(o *queryStats) *queryStats {
s.blocksQueried += o.blocksQueried

s.postingsToFetch += o.postingsToFetch
s.postingsTouched += o.postingsTouched
s.PostingsTouchedSizeSum += o.PostingsTouchedSizeSum
s.postingsFetched += o.postingsFetched
Expand Down

0 comments on commit 5fe9ddc

Please sign in to comment.