Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
kakkoyun and pracucci committed Jun 5, 2020
1 parent cf9ec45 commit 68c149a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/store/bucket.go
Expand Up @@ -218,13 +218,13 @@ func newBucketStoreMetrics(reg prometheus.Registerer) *bucketStoreMetrics {
})

m.postingsFetchDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
Name: "thanos_bucket_store_series_fetch_duration_seconds",
Name: "thanos_bucket_store_postings_fetch_duration_seconds",
Help: "Time it takes to fetch postings to respond a query.",
Buckets: []float64{0.001, 0.01, 0.1, 0.3, 0.6, 1, 3, 6, 9, 20, 30, 60, 90, 120},
})
m.seriesFetchDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
Name: "thanos_bucket_store_postings_fetch_duration_seconds",
Help: "Time it takes to fetch sub-results to respond a query.",
Name: "thanos_bucket_store_series_fetch_duration_seconds",
Help: "Time it takes to fetch series to respond a query.",
Buckets: []float64{0.001, 0.01, 0.1, 0.3, 0.6, 1, 3, 6, 9, 20, 30, 60, 90, 120},
})
m.chunksFetchDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
Expand Down Expand Up @@ -982,7 +982,7 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_Serie
s.metrics.cachedPostingsOriginalSizeBytes.Add(float64(stats.cachedPostingsOriginalSizeSum))
s.metrics.cachedPostingsCompressedSizeBytes.Add(float64(stats.cachedPostingsCompressedSizeSum))
s.metrics.postingsFetchDuration.Observe(stats.postingsFetchDurationSum.Seconds())
s.metrics.chunksFetchDuration.Observe(stats.postingsFetchDurationSum.Seconds())
s.metrics.chunksFetchDuration.Observe(stats.chunksFetchDurationSum.Seconds())
s.metrics.seriesFetchDuration.Observe(stats.seriesFetchDurationSum.Seconds())

level.Debug(s.logger).Log("msg", "stats query processed",
Expand Down

0 comments on commit 68c149a

Please sign in to comment.