Skip to content

Commit

Permalink
unhide disable-downsampling flag in compactor
Browse files Browse the repository at this point in the history
Signed-off-by: yeya24 <yb532204897@gmail.com>
  • Loading branch information
yeya24 committed Aug 8, 2019
1 parent bdcad16 commit 8317a30
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/thanos/compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application) {
Hidden().Default("false").Bool()

// TODO(bplotka): Remove this flag once https://github.com/thanos-io/thanos/issues/297 is fixed.
disableDownsampling := cmd.Flag("debug.disable-downsampling", "Disables downsampling. This is not recommended "+
disableDownsampling := cmd.Flag("disable-downsampling", "Disables downsampling. This is not recommended "+
"as querying long time ranges without non-downsampled data is not efficient and not useful (is not possible to render all for human eye).").
Hidden().Default("false").Bool()
Default("false").Bool()

maxCompactionLevel := cmd.Flag("debug.max-compaction-level", fmt.Sprintf("Maximum compaction level, default is %d: %s", compactions.maxLevel(), compactions.String())).
Hidden().Default(strconv.Itoa(compactions.maxLevel())).Int()
Expand Down
4 changes: 4 additions & 0 deletions docs/components/compact.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ Flags:
hour) in bucket. 0d - disables this retention
-w, --wait Do not exit after all compactions have been
processed and wait for new work.
--disable-downsampling Disables downsampling. This is not recommended as
querying long time ranges without non-downsampled
data is not efficient and not useful (is not
possible to render all for human eye).
--block-sync-concurrency=20
Number of goroutines to use when syncing block
metadata from object storage.
Expand Down

0 comments on commit 8317a30

Please sign in to comment.