Address feedback

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>

pkg/store/bucket.go

@@ -509,6 +509,7 @@ func NewBucketStore(
 		enableSeriesResponseHints:   enableSeriesResponseHints,
 		enableChunkHashCalculation:  enableChunkHashCalculation,
 		seriesBatchSize:             SeriesBatchSize,
+		labelNamesBloom:             bloom.NewAlwaysTrueFilter(),
 	}
 
 	for _, option := range options {
@@ -1681,13 +1682,15 @@ func (s *BucketStore) UpdateLabelNamesBloom(ctx context.Context) error {
 				extRes = append(extRes, l.Name)
 			}
 
-			res = strutil.MergeSlices(res, extRes)
-
 			if len(res) > 0 {
 				mtx.Lock()
 				for _, n := range res {
 					names[n] = struct{}{}
 				}
+
+				for _, n := range extRes {
+					names[n] = struct{}{}
+				}
 				mtx.Unlock()
 			}
 

pkg/store/proxy.go

@@ -156,6 +156,7 @@ func NewProxyStore(
 		responseTimeout:     responseTimeout,
 		metrics:             metrics,
 		retrievalStrategy:   retrievalStrategy,
+		labelNamesBloom:     bloom.NewAlwaysTrueFilter(),
 		internalLabelResort: true,
 	}
 

pkg/store/proxy_heap.go

@@ -906,7 +906,7 @@ func hasInternalReplicaLabels(st Client, req *storepb.SeriesRequest, internalLab
 	bloom := st.LabelNamesBloom()
 	// Empty bloom filter capacity is 1. We fallback to eager retrieval if bloom filter
 	// is yet to be updated, as we cannot yet determine if the store has internal replica labels.
-	if bloom == nil || bloom.Cap() <= 1 {
+	if bloom.Cap() <= 1 {
 		return true
 	}