Skip to content

Commit

Permalink
Fix ketama quorum (#5910)
Browse files Browse the repository at this point in the history
* Fix quorum calculation for Ketama hashring

The quorum calculation is currently broken when using the Ketama
hashring. The reasons are explained in detail in issue
#5784.

This commit fixes quorum calculation by tracking successfull writes
for each individual time-series inside a remote-write request.

The commit also removes the replicate() method inside the Handler
and moves the entire logic of fanning out and calculating success
into the fanoutForward() method.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Fix error propagation

Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>

* Fix writer errors

Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>

* Separate write from replication errors

Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>

* Add back replication metric

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Address PR comments

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Address code review comments

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
  • Loading branch information
fpetkovski committed Dec 15, 2022
1 parent a4b34cd commit d76c723
Show file tree
Hide file tree
Showing 3 changed files with 456 additions and 760 deletions.

0 comments on commit d76c723

Please sign in to comment.