Skip to content

Commit

Permalink
Update in the alternative approach
Browse files Browse the repository at this point in the history
Signed-off-by: Harshitha1234 <harshithachowdary.t17@iiits.in>
  • Loading branch information
Harshitha1234 committed Jul 8, 2020
1 parent 22884ae commit e62fcd6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/proposals/deletions_object_storage.md
Expand Up @@ -4,7 +4,7 @@ type: proposal
menu: proposals
status: draft
owner: bwplotka, Harshitha1234, metalmatze
---
---

### Ticket: https://github.com/thanos-io/thanos/issues/1598
## Summary
Expand Down Expand Up @@ -47,7 +47,7 @@ The main motivation for considering deletions in the object storage are the foll
* **Performing deletes on already compacted blocks:** Have a threshold to perform deletions on the compacted blocks ([In Prometheus](https://github.com/prometheus/prometheus/blob/f0a439bfc5d1f49cec113ee9202993be4b002b1b/tsdb/compact.go#L213), the blocks with big enough time range, that have >5% tombstones, are considered for compaction.)
* For undoing deletions of a time series there are two proposed ways
* API to undelete a time series - maybe delete the whole tombstones file?
* “Imaginary” deletion that can delete other tombstones
* “Imaginary” deletion that can delete other tombstones

Considerations :

Expand Down

0 comments on commit e62fcd6

Please sign in to comment.