Skip to content

Commit

Permalink
Log prometheus config reload error instead of stopping sidecar
Browse files Browse the repository at this point in the history
Signed-off-by: Max Neverov <neverov.max@gmail.com>
  • Loading branch information
mneverov committed Aug 6, 2020
1 parent 2b3dd70 commit f2a3fdb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/reloader/reloader.go
Expand Up @@ -218,9 +218,7 @@ func (r *Reloader) Watch(ctx context.Context) error {
}

if err := r.apply(ctx); err != nil {
// Critical error.
// TODO(bwplotka): There is no need to get process down in this case and decrease availability, handle the error in different way.
return err
level.Error(r.logger).Log("msg", "apply error", "err", err)
}
}
}
Expand Down

0 comments on commit f2a3fdb

Please sign in to comment.