Skip to content

Commit

Permalink
Mixin: Remove dependency on the rule dashboard when generating the co…
Browse files Browse the repository at this point in the history
…mpact dashboard.
  • Loading branch information
goober committed Apr 7, 2021
1 parent 7a5955b commit fd2eeeb
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions mixin/dashboards/compact.libsonnet
Expand Up @@ -35,7 +35,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_group_compactions_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_group_compactions_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
)
Expand All @@ -57,7 +57,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_downsample_failed_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_downsample_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
)
Expand All @@ -79,12 +79,12 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_garbage_collection_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_garbage_collection_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute garbage collection in quantiles.') +
g.latencyPanel('thanos_compact_garbage_collection_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_compact_garbage_collection_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
Expand Down Expand Up @@ -139,12 +139,12 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_blocks_meta_sync_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_blocks_meta_syncs_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute meta file sync, in quantiles.') +
g.latencyPanel('thanos_blocks_meta_sync_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_blocks_meta_sync_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
Expand All @@ -162,16 +162,16 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_objstore_bucket_operation_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_objstore_bucket_operations_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute operations against the bucket, in quantiles.') +
g.latencyPanel('thanos_objstore_bucket_operation_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_objstore_bucket_operation_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
g.resourceUtilizationRow(thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.resourceUtilizationRow(thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
),

__overviewRows__+:: [
Expand All @@ -196,7 +196,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_group_compactions_failures_total{%(selector)s}' % thanos.dashboard.overview.selector,
'thanos_compact_group_compactions_total{%(selector)s}' % thanos.dashboard.overview.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
) +
g.addDashboardLink(thanos.compact.title)
) +
Expand Down

0 comments on commit fd2eeeb

Please sign in to comment.