Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument http_request_duration_seconds metric with exemplars #3944

Closed
yeya24 opened this issue Mar 19, 2021 · 1 comment · Fixed by #3977
Closed

Instrument http_request_duration_seconds metric with exemplars #3944

yeya24 opened this issue Mar 19, 2021 · 1 comment · Fixed by #3977

Comments

@yeya24
Copy link
Contributor

yeya24 commented Mar 19, 2021

From the discussion #3938, we think it is a good start to instrument https://github.com/thanos-io/thanos/blob/main/pkg/extprom/http/instrument_server.go#L44 with Exemplars.

Exemplar example:

  1. Add exemplar support to middleware weaveworks/common#202

Help is welcomed!

@metalmatze
Copy link
Member

I am going to assign this to myself as I got it working from a Thanos standpoint for the most part. 🎉
Screenshot from 2021-03-26 01-44-35
Right now I'm unable to actually make it work in Grafana, but that should be all for the most part.

Probably, worth noting that I had to use the histogramVec directly as client_golang ObserveWithExemplar doesn't work with currying right now. I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants