Add Exemplars for http_request_duration_seconds histogram #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> A lot of these changes are actually changing the order of calling the middlwares. Going forward we need to make sure to first call the tracing middleware so that by the time our monitoring/instrumentation middleware gets hit the tracing spans are already populated.
bwplotka
approved these changes
Mar 26, 2021
yeya24
reviewed
Mar 26, 2021
| // If we find a tracingID we'll expose it as Exemplar. | ||
| span := opentracing.SpanFromContext(r.Context()) | ||
| if span != nil { | ||
| spanCtx, ok := span.Context().(jaeger.SpanContext) |
There was a problem hiding this comment.
Here we just support Jaeger tracer? Is it compatible with lightstep, stackdriver, etc?
| if span != nil { | ||
| spanCtx, ok := span.Context().(jaeger.SpanContext) | ||
| if ok { | ||
| observer.(prometheus.ExemplarObserver).ObserveWithExemplar( |
There was a problem hiding this comment.
Like in the weaveworks example https://github.com/weaveworks/common/pull/202/files#diff-29d7cb6219a01fc80b731ac8004ac0f5edd5a1be507b164939ba4a4d1caf9ac2R70, I think we also need to check for sampled trace ID.
|
Let's iterate over it @yeya24 good points. Also I would see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Prometheus HTTP handler now enables OpenMetrics as response format upon content negotiation.
You can test it by running
curl -s -H 'Accept: application/openmetrics-text' localhost:10904/metricsThis allows us to pass a
traceIDtoObserveWithExemplar.A lot of the other changes are actually changing the order of calling the middlewares.
Going forward we need to make sure to first call the tracing middleware so that by the time our monitoring/instrumentation middleware gets hit the tracing spans are already populated.
Verification
Tested locally with Jaeger and Prometheus running
--enable-feature=exemplar-storage.Closes #3944