Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: Support limit feature introduced by Prometheus v2.31.0 #4837

Closed
hanjm opened this issue Nov 7, 2021 · 2 comments
Closed

Rule: Support limit feature introduced by Prometheus v2.31.0 #4837

hanjm opened this issue Nov 7, 2021 · 2 comments
Labels
component: rule feature request/improvement

Comments

@hanjm
Copy link
Member

hanjm commented Nov 7, 2021 •
edited

Is your proposal related to a problem?

Prometheus v2.31.0 introduce a new feature about rules: add the ability to limit number of alerts or series. prometheus/prometheus#9541
I'd like to implement this feature with thanos-ruler :)

Describe the solution you'd like

Describe alternatives you've considered

Additional context
hanjm added a commit to hanjm/thanos that referenced this issue Nov 7, 2021
@hanjm
Rule: Support ruleGroup limit (thanos-io#4837)
ecd65a8 
Signed-off-by: Jimmiehan <hanjinming@outlook.com>
@yeya24
Copy link
Contributor

yeya24 commented Nov 7, 2021

Please go ahead!

hanjm added a commit to hanjm/thanos that referenced this issue Nov 14, 2021
@hanjm
Rule: Support ruleGroup limit (thanos-io#4837)
84f8150 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm hanjm mentioned this issue Nov 14, 2021
Merged
2 tasks
hanjm added a commit to hanjm/thanos that referenced this issue Nov 17, 2021
@hanjm
Rule: Support ruleGroup limit (thanos-io#4837)
2738f1c 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
yeya24 pushed a commit that referenced this issue Nov 19, 2021
@hanjm
Rule: Support ruleGroup limit (#4868)
243526d 
* Rule: Support ruleGroup limit (#4837)

Signed-off-by: Jimmie Han <hanjinming@outlook.com>

* Rules: format rpc.proto

Signed-off-by: Jimmie Han <hanjinming@outlook.com>

* Rules: fix unit test

Signed-off-by: Jimmie Han <hanjinming@outlook.com>

* Rules: add e2e test

Signed-off-by: Jimmie Han <hanjinming@outlook.com>

* Rules: add e2e rule test case hit limit

Signed-off-by: Jimmie Han <hanjinming@outlook.com>

* fix unit test ci, use runutil.Retry instead of time.Sleep.

Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@yeya24
Copy link
Contributor

yeya24 commented Nov 19, 2021 •
edited

Closed by #4868

@yeya24 yeya24 closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: rule feature request/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanjm @yeya24