Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subqueries on Vertical Sharding #5811

Closed
alanprot opened this issue Oct 21, 2022 · 0 comments · Fixed by #5846
Closed

Support subqueries on Vertical Sharding #5811

alanprot opened this issue Oct 21, 2022 · 0 comments · Fixed by #5846

Comments

@alanprot
Copy link
Contributor

alanprot commented Oct 21, 2022

Is your proposal related to a problem?

As for right now any query that has a subquery are not sharded.

For instance the following query is shardable avg(kube_pod_container_status_running) by (pod, namespace, cluster_id) but not avg(kube_pod_container_status_running[1h:1m]) by (pod, namespace, cluster_id)

See:

case *parser.SubqueryExpr:
isShardable = false
return fmt.Errorf("expressions with subqueries are not shardable")

Describe the solution you'd like

Seems like queries like avg(kube_pod_container_status_running[1h:1m]) by (pod, namespace, cluster_id) could also take advantage of the query vertical sharding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants