Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard subqueries #5846

Merged
merged 2 commits into from Nov 2, 2022
Merged

Shard subqueries #5846

merged 2 commits into from Nov 2, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 2, 2022

Signed-off-by: Ben Ye benye@amazon.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Fixes #5811

Changes

Subqueries should be also shardable.

Verification

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Nov 2, 2022

I will go ahead and merge it since it is a small change.

@yeya24 yeya24 enabled auto-merge (squash) November 2, 2022 16:21
@yeya24 yeya24 disabled auto-merge November 2, 2022 16:22
@yeya24 yeya24 merged commit 50b4156 into thanos-io:main Nov 2, 2022
@yeya24
Copy link
Contributor Author

yeya24 commented Nov 2, 2022

I think I missed one thing. On the query frontend side we should also support Matrix as the result type when merging responses. Will follow up in next PR.

@yeya24 yeya24 deleted the shard-subquery branch November 7, 2022 17:27
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
* shard subqueries

Signed-off-by: Ben Ye <benye@amazon.com>

* update changelog

Signed-off-by: Ben Ye <benye@amazon.com>

Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subqueries on Vertical Sharding
2 participants