compact: compact still tries to downsample the block, when it has the no-downsample-mark.json #6179
Comments
|
Similar issue here. |
GiedriusS
added a commit
that referenced
this issue
Nov 14, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes #6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
that referenced
this issue
Nov 15, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes #6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
yeya24
pushed a commit
that referenced
this issue
Nov 19, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes #6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
to vinted/thanos
that referenced
this issue
Nov 23, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes thanos-io#6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this issue
Dec 13, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes thanos-io#6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this issue
Dec 13, 2023
We have a NoDownsampleMarkFilter that we were not using before in the compactor for some reason. Hook it into the filters chain if downsampling is enabled and then trim matching ULIDs from the downsampling process. Add a test to cover this scenario. Fixes thanos-io#6179. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanos, Prometheus and Golang version used: Thanos v0.30.2
Object Storage Provider: ceph
What happened:
I have a block that is broken, and when it was downsampled, the compact will halt with failed checksums.
So i I want to skip the downsamp for this block by the #5945 .
But when I marked this block with
no-downsample-mark.json, the compact still halt because of this block.What you expected to happen:
The compact skipping the downsamp of this block.
Anything else we need to know:
I checked the source code after the problem, and found that there is a function
NoDownsampleMarkedBlocks()for finding marked blocks, which is defined but not used. Maybe it has something to do with this?thanos/pkg/compact/downsample/downsample.go
Lines 790 to 791 in fe3f5d2
The text was updated successfully, but these errors were encountered: