Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minio dep to pull in retry fix #1190

Merged
merged 2 commits into from May 30, 2019

Conversation

mattrco
Copy link
Contributor

@mattrco mattrco commented May 29, 2019

Changes

minio-go updates to pull in a fix for retrying HTTP timeouts: minio/minio-go#1116

Note the import path has changed.

Changes from the last version:

$ git show-branch f33eae714a282af20fb59f4a3bf27fdb1d92bf6a de69c0e465ed3608f3be32f2488af7b481b88e53
! [f33eae714a282af20fb59f4a3bf27fdb1d92bf6a] support new ap-east-1 region (#1105)
 ! [de69c0e465ed3608f3be32f2488af7b481b88e53] Retry errors caused by a timeout waiting for the server response (#1116)
--
 + [de69c0e465ed3608f3be32f2488af7b481b88e53] Retry errors caused by a timeout waiting for the server response (#1116)
 + [de69c0e465ed3608f3be32f2488af7b481b88e53^] Update version to next release
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~2] Increase default multipart size to 128MiB (#1112)
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~3] Fix go module imports properly to honor semantic versioning (#1111)
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~4] Update version to next release
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~5] Allow domains with . at the end (#1110)
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~6] Retry on 504 Gateway timeout http status code. (#1104)
 + [de69c0e465ed3608f3be32f2488af7b481b88e53~7] [api] enable error tracing (#1091)
++ [f33eae714a282af20fb59f4a3bf27fdb1d92bf6a] support new ap-east-1 region (#1105)

go get github.com/minio/minio-go/v6@de69c0e465ed3608f3be32f2488af7b481b88e53
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This makes sense, but not sure why go.mod is duplicated (:

@mattrco
Copy link
Contributor Author

mattrco commented May 30, 2019

@bwplotka the duplicated import lines in go.sum? This confused me too, but I think it's intended behaviour as it's meant to be a record of all modules "seen". More info in this comment: golang/go#26381 (comment)

@bwplotka bwplotka merged commit ee01efb into thanos-io:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants