Add Support for retries when using Azure Blob Storage #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Jun 14, 2019
povilasv
approved these changes
Jun 17, 2019
|
@bwplotka -- is there anything else you guys need from me in order to merge this? |
|
No, looks perfect. Let's rebase and I will merge (: Sorry for delay. |
|
I think I rebased it correctly... Only my second time having to do a rebase though, so let me know if I messed anything up 😛 Thanks, Bartek! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1252
Changelog entry:
Changes
Add field to Azure configuration to allow for specifying "maxretries".
This retry value is used when creating a pipeline (most operations do this for things like stat'ing the bucket) and when downloading the bucket's context.
(Note: the Azure library does not currently support retries for uploads or for deletions).
Verification
All tests pass. Verified
query,store,bucket inspect,bucket lscommands all work.