Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1272: add bugfix to changelog #1283

Closed
wants to merge 1 commit into from
Closed

Conversation

lx223
Copy link
Contributor

@lx223 lx223 commented Jun 27, 2019

  • [] CHANGELOG entry if change is relevant to the end user.

Changes

Add #1280 to changelog

Verification

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (: tiny thing only.

@@ -17,6 +17,8 @@ We use *breaking* word for marking changes that are not backward compatible (rel

- [#1253](https://github.com/improbable-eng/thanos/pull/1253) Add support for specifying a maximum amount of retries when using Azure Blob storage (default: no retries).

- [#1280](https://github.com/improbable-eng/thanos/pull/1280) Fixed an concurrent map write issue that caused panics when rendering HTML in query UI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [#1280](https://github.com/improbable-eng/thanos/pull/1280) Fixed an concurrent map write issue that caused panics when rendering HTML in query UI
- [#1280](https://github.com/improbable-eng/thanos/pull/1280) Fixed a concurrent map write issue that caused panics when rendering HTML in query UI.

@GiedriusS
Copy link
Member

Thanks for this but while releasing 0.6.0-rc.0 I have added this myself to the CHANGELOG.md file, didn't see this PR. Cheers for the fix! 👍

@GiedriusS GiedriusS closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants