Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make label flag consistent in receive and rule #1498

Merged
merged 3 commits into from
Sep 7, 2019

Conversation

Wing924
Copy link
Contributor

@Wing924 Wing924 commented Sep 6, 2019

Signed-off-by: Wing924 weihe924stephen@gmail.com

fixes #1497

  • [] CHANGELOG entry if change is relevant to the end user.

Changes

Verification

Signed-off-by: Wing924 <weihe924stephen@gmail.com>
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@FUSAKLA
Copy link
Member

FUSAKLA commented Sep 6, 2019

Maybe it should be also fixed in the quickstart.sh and e2e spinup test?

Signed-off-by: Wing924 <weihe924stephen@gmail.com>
@Wing924
Copy link
Contributor Author

Wing924 commented Sep 7, 2019

@FUSAKLA
I fixed quickstart.sh and e2e spinup test.

Copy link
Member

@FUSAKLA FUSAKLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@brancz brancz merged commit cfacb10 into thanos-io:master Sep 7, 2019
@Wing924 Wing924 deleted the fix_receive_label_flag branch September 7, 2019 13:58
wbh1 pushed a commit to wbh1/thanos that referenced this pull request Sep 17, 2019
* make label flag consistent in receive and rule

Signed-off-by: Wing924 <weihe924stephen@gmail.com>

* fix test

Signed-off-by: Wing924 <weihe924stephen@gmail.com>

* fix quickstart

Signed-off-by: Wing924 <weihe924stephen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receive use labels flag while rule use label flag
4 participants