Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compactor constants, fix bucket column #1561

Merged
merged 3 commits into from Sep 25, 2019

Commits on Sep 23, 2019

  1. compact: unify different time constants

    Use downsample.* constants where possible. Move the downsampling time
    ranges into constants and use them as well.
    
    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    GiedriusS committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    e354c53 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. bucket: refactor column calculation into compact

    Fix the column's name and name it UNTIL-DOWN because that is what it
    actually shows - time until the next downsampling.
    
    Move out the calculation into a separate function into the compact
    package. Ideally we could use the retention policies in this calculation
    as well but the `bucket` subcommand knows nothing about them :-(
    
    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    GiedriusS committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d44b514 View commit details
    Browse the repository at this point in the history
  2. compact: fix issues with naming

    Reorder the constants and fix mistakes.
    
    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    GiedriusS committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    74504c7 View commit details
    Browse the repository at this point in the history