-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test. #1669
Conversation
f1ba562
to
30f7b87
Compare
test failed ): |
30f7b87
to
8b85077
Compare
…sharding e2e test. Fixes: #1664 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
8b85077
to
f4ec30e
Compare
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
3b6ac56
to
6d61779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from a Go perspective mostly :)
It's not super clear why CI failed, any ideas? |
Yea, I am busy with other things, but it looks like
our |
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
…sharding e2e test. (#1669) * store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test. Fixes: #1664 Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Trying to speed up tests a bit. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> * Fixed tests. Signed-off-by: Bartek Plotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Fixes: #1664
Signed-off-by: Bartek Plotka bwplotka@gmail.com