Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querier: Actually use select Start,End params during select. #1675

Merged
merged 1 commit into from Oct 22, 2019
Merged

querier: Actually use select Start,End params during select. #1675

merged 1 commit into from Oct 22, 2019

Conversation

bwplotka
Copy link
Member

This will definitely helps with offset queries.

Same was done on cortexproject/cortex#1012

Signed-off-by: Bartek Plotka bwplotka@gmail.com

@bwplotka bwplotka changed the title querier: Actually use select mint,maxt params during select. querier: Actually use select Start,End params during select. Oct 22, 2019
@squat
Copy link
Member

squat commented Oct 22, 2019

nice catch! looks good, just need to update a test, it seems.

--- FAIL: TestEndpoints (0.02s)
    --- FAIL: TestEndpoints/end=-1&match%5B%5D=test_metric2&start=-2 (0.00s)
        v1_test.go:831: Response does not match, expected:
            []
            got:
            [{__name__="test_metric2", foo="boo"}]
FAIL
FAIL	github.com/thanos-io/thanos/pkg/query/api	0.033s

@bwplotka
Copy link
Member Author

It was actually bug, so test helped. Should be fine now 👍

@bwplotka
querier: Actually use select mint,maxt params during select.
f35d0cd 
This will definitely helps with offset queries.

Same was done on cortexproject/cortex#1012

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
squat
squat approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🌮

@brancz brancz merged commit 1dc7299 into master Oct 22, 2019
@brancz brancz deleted the querier-store branch October 22, 2019 14:17
@brian-brazil
Copy link
Contributor

This is okay, as long as you're using a new enough version of Prometheus that actually sends these.

@bwplotka
Copy link
Member Author

Good point, we plan to fetch latest Prometheus soon as well.

GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
@bwplotka @GiedriusS
querier: Actually use select mint,maxt params during select. (#1675)
37ae6dd 
This will definitely helps with offset queries.

Same was done on cortexproject/cortex#1012

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

@squat squat squat approved these changes

@domgreen domgreen Awaiting requested review from domgreen

@metalmatze metalmatze Awaiting requested review from metalmatze

@GiedriusS GiedriusS Awaiting requested review from GiedriusS

@FUSAKLA FUSAKLA Awaiting requested review from FUSAKLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwplotka @squat @brian-brazil @brancz