Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added experimental filesystem bucket implementation #1690

Merged
merged 3 commits into from Oct 29, 2019
Merged

Conversation

bwplotka
Copy link
Member

Usa cases:

Signed-off-by: Bartek Plotka bwplotka@gmail.com

Usa cases:
* See: observatorium/thanos-replicate#7
* Local testing, demos

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
@metalmatze
Copy link
Member

Please rename to "block storage object storage" 😂

@bwplotka
Copy link
Member Author

bwplotka commented Oct 28, 2019

Technically I should rename it to flat filesystem as the main different vs object storage and filesystem is a hierarchy...

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We came full circle! 😄 It seems like you have tests failing.

Copy link
Member

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jojohappy jojohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

🚢 ! Thanks all for review!

@bwplotka bwplotka merged commit b7f3ac9 into master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants