cmd/thanos/receive: dont upload as sidecar #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Dec 12, 2019
cmd/thanos/receive.go
Outdated
| @@ -407,7 +407,7 @@ func runReceive( | |||
| if upload { | |||
| // The background shipper continuously scans the data directory and uploads | |||
| // new blocks to Google Cloud Storage or an S3-compatible storage service. | |||
| bkt, err := client.NewBucket(logger, confContentYaml, reg, component.Sidecar.String()) | |||
| bkt, err := client.NewBucket(logger, confContentYaml, reg, component.Receive.String()) | |||
There was a problem hiding this comment.
We have the “comp” variable that we can use here no?
There was a problem hiding this comment.
yes, absolutely right. it turns out we are explicitly using component.Receive somewhere else in this body as well because tsdb.NewTSDBStore expects a component.SourceStoreAPI, not just a component.Component. I'll change the function signature of runReceive and update both of these.
squat
force-pushed
the
uploadassidecar
branch
from
bf008cc
to
0ee9050
Compare
As pointed out by a user on the CNCF Slack, the receiver is currently uploading to object storage as the sidecar. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
force-pushed
the
uploadassidecar
branch
from
0ee9050
to
5500699
Compare
brancz
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by a user on the CNCF Slack, the receiver is currently
uploading to object storage as the sidecar.
cc @metalmatze @brancz
Signed-off-by: Lucas Servén Marín lserven@gmail.com