Use block.MetaFetcher in Store Gateway. #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
apply-meta-syncer-store
branch
from
949fd2c
to
200d930
Compare
bwplotka
force-pushed
the
apply-meta-syncer-store
branch
4 times, most recently
from
e9a646e
to
8172e0a
Compare
metalmatze
approved these changes
Jan 6, 2020
povilasv
approved these changes
Jan 6, 2020
|
|
||
| if err := os.MkdirAll(dir, os.ModePerm); err != nil { | ||
| return errors.Wrap(err, "create dir") |
There was a problem hiding this comment.
Suggested change
| return errors.Wrap(err, "create dir") | |
| return errors.Wrapf(err, "create dir %s", dir) |
There was a problem hiding this comment.
Not needed as MkdirAll error will put path inside error.
bwplotka
force-pushed
the
apply-meta-syncer-store
branch
from
8172e0a
to
63bfaf9
Compare
Fixes: #1874 * Corrupted disk cache for meta.json is handled gracefully. * Synchronize was not taking into account deletion by removing meta.json. * Prepare for future implementation of https://thanos.io/proposals/201901-read-write-operations-bucket.md/ * Better observability for syncronize process. * More logs for store startup process. TODO in separate PR: * More observability for index-cache loading / adding time. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
apply-meta-syncer-store
branch
from
63bfaf9
to
a654fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1874
Depends on: #1934
Changes
TODO in separate PR:
Verification
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com