mixin: Add Thanos Ruler alerts #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
metalmatze
reviewed
Jan 8, 2020
metalmatze
reviewed
Jan 8, 2020
metalmatze
requested changes
Jan 8, 2020
Comment on lines
+78
to
+81
| sum by (job, pod, rule_group) (prometheus_rule_group_last_duration_seconds{%(selector)s}) | ||
| > | ||
| sum by (job, pod, rule_group) (prometheus_rule_group_interval_seconds{%(selector)s}) | ||
| ) |
There was a problem hiding this comment.
I'm not too sure about this rule, as it's always evaluation for us, even though everything seems fine.
There was a problem hiding this comment.
This still indicates a problem though. Its severity set to warning. We might also give a coefficient for the interval but I think we should have this.
With this alert, you can detect you have too many rules for a group for example. Or your queries take too much time.
It's not very critical but I still see value in this.
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
|
@metalmatze ping |
metalmatze
approved these changes
Jan 13, 2020
|
@metalmatze Could you merge? Or should we wait for another opinion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing Ruler alerts to thanos-mixin.
Alerts are inspired by https://thanos.io/components/rule.md/#must-have-essential-ruler-alerts
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Changes
Verification
For rules:
make example-rules-lintFor dashboards: