Fixed crash in the memcached servers selector when there's only 1 server #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
GiedriusS
reviewed
Jan 9, 2020
| actualAddr, err := s.PickServer(test.key) | ||
|
|
||
| if test.expectedErr != nil { | ||
| testutil.NotOk(t, err) |
There was a problem hiding this comment.
We forgot to check that err is equal to test.expectedErr here :P
There was a problem hiding this comment.
Thanks for noticing it! Fixed
Signed-off-by: Marco Pracucci <marco@pracucci.com>
GiedriusS
approved these changes
Jan 9, 2020
|
Thanks for this quick reaction ❤️ |
GiedriusS
pushed a commit
to GiedriusS/thanos
that referenced
this pull request
Jan 10, 2020
…ver (thanos-io#1975) * Fixed crash in the memcached servers selector when there's only 1 server Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated changelog Signed-off-by: Marco Pracucci <marco@pracucci.com> * Assert expected error in tests Signed-off-by: Marco Pracucci <marco@pracucci.com>
GiedriusS
added a commit
that referenced
this pull request
Jan 10, 2020
* Fixed crash in the memcached servers selector when there's only 1 server (#1975) * Fixed crash in the memcached servers selector when there's only 1 server Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated changelog Signed-off-by: Marco Pracucci <marco@pracucci.com> * Assert expected error in tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * *: update everything for 0.10.0-rc.1 Update the version strings before the `0.10.0-rc.1` release. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1974
Verification
Unit tests.