Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register thanos_alert_sender_errors_total metric. #2101

Merged
merged 2 commits into from Feb 5, 2020
Merged

Register thanos_alert_sender_errors_total metric. #2101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893be12
Register thanos_alert_sender_errors_total metric.
OGKevin Feb 5, 2020
b0f30b8
Updated CHANGELOG.
OGKevin Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#2033](https://github.com/thanos-io/thanos/pull/2033) minio-go: Fixed Issue #1494 support Web Identity providers for IAM credentials for AWS EKS
- [#1985](https://github.com/thanos-io/thanos/pull/1985) store gateway: Fixed case where series entry is larger than 64KB in index.
- [#2051](https://github.com/thanos-io/thanos/pull/2051) ruler: Fixed issue where ruler does not expose shipper metrics.
- [#2101](https://github.com/thanos-io/thanos/pull/2101) ruler: Fixed bug where thanos_alert_sender_errors_total was not registered.

### Added

Expand Down
2 changes: 1 addition & 1 deletion pkg/alert/alert.go
View file
Open in desktop
Expand Up @@ -313,7 +313,7 @@ func NewSender(
}, []string{"alertmanager"}),
}
if reg != nil {
reg.MustRegister(s.sent, s.dropped, s.latency)
reg.MustRegister(s.sent, s.errs, s.dropped, s.latency)
}
return s
}
Expand Down