.*: Verify if deletion marker file exists before using it. #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes problem with Get method reporting missing file as failures (via metrics). Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
changed the title
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
2 tasks
pracucci
reviewed
Apr 3, 2020
| // BucketReader.Get reports missing file as a failure (via metrics), | ||
| // but since most blocks don't have this marker file, it skews metrics unnecessarily. | ||
| // By using exists first, we avoid that. | ||
| exists, err := bkt.Exists(ctx, deletionMarkFile) |
There was a problem hiding this comment.
I'm dubious about having to do another API call just to check if the object exists, when we can get the same information from Get(). I personally believe #2365 works better (my take here).
|
See discussion here: #2365 and on slack https://cloud-native.slack.com/archives/CL25937SP/p1585903230146500 |
|
Alternative we agrred offline for: #2370 Let me know if that's make sense 🤗 |
|
Fix merged #2383 |
|
Thanks for help on this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2365. Please see the problem description there. This PR modifies
ReadDeletionMarkfunction to useExistscall before reading deletion marker file. This helps to keepthanos_objstore_bucket_operation_failures_totaldown, since missing deletion marker file is not really a failure.