Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objstore: Added WithExpectedErrs which allows to control instrumentation (e.g not increment failures for expected not found) #2383

Merged
merged 2 commits into from Apr 6, 2020
Merged

objstore: Added WithExpectedErrs which allows to control instrumentation (e.g not increment failures for expected not found) #2383

merged 2 commits into from Apr 6, 2020

Commits on Apr 6, 2020

  1. objstore: Added WithExpectedErrs to Reader which allows to control in… 

    …strumentation (e.g not increment failures for expected not found).

This allows to not wake up oncall in the middle of night, becuase of expeced, properly handled case (:

Also: Has to move inmem to objstore for testing.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    @bwplotka @squat
    bwplotka authored and squat committed Apr 6, 2020
    Copy the full SHA
    628b6f2 View commit details
    Browse the repository at this point in the history

  2. pkg/objstore: fix NewBucket comments. 

    This commit fixes the documentation comments for the NewBucket funcs.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
    @squat
    squat committed Apr 6, 2020
    Copy the full SHA
    2efe1fc View commit details
    Browse the repository at this point in the history