New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rule Group Evaluations to Ruler dashboard in mixin #2602
Add Rule Group Evaluations to Ruler dashboard in mixin #2602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
@metalmatze CI shows some uncommitted generated files. |
@metalmatze Friendly ping :) |
Nice. Let me import this PR into my Grafana to take a look at it. 😊 |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@metalmatze friendly ping :) This PR needs some love. |
Oh, I completely forgot about this one. 😂 |
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
b82a65c
to
13e3e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
In #2398 we added a ThanosNoRuleEvaluations alert which is really helpful and signaling a symptom of unavailability of the Thanos Ruler. Sadly we don't surface these underlying metrics on the Thanos Ruler dashboard.
Changes
Add some panel to the Thanos Ruler dashboard.
Verification
Deployed the new Thanos Ruler dashboard on Grafana and check against our datasource :)