Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rule Group Evaluations to Ruler dashboard in mixin #2602

Merged
merged 1 commit into from Aug 20, 2020

Conversation

metalmatze
Copy link
Member

In #2398 we added a ThanosNoRuleEvaluations alert which is really helpful and signaling a symptom of unavailability of the Thanos Ruler. Sadly we don't surface these underlying metrics on the Thanos Ruler dashboard.

Screenshot from 2020-05-13 19-51-10

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add some panel to the Thanos Ruler dashboard.

Verification

Deployed the new Thanos Ruler dashboard on Grafana and check against our datasource :)

Copy link
Member

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@kakkoyun
Copy link
Member

@metalmatze CI shows some uncommitted generated files.

@kakkoyun
Copy link
Member

@metalmatze Friendly ping :)

@metalmatze
Copy link
Member Author

Nice. Let me import this PR into my Grafana to take a look at it. 😊

@stale
Copy link

stale bot commented Aug 14, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Aug 14, 2020
@kakkoyun kakkoyun removed the stale label Aug 14, 2020
@kakkoyun
Copy link
Member

@metalmatze friendly ping :) This PR needs some love.

@metalmatze
Copy link
Member Author

Oh, I completely forgot about this one. 😂
Let me give it another look!

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kakkoyun kakkoyun merged commit 553f230 into thanos-io:master Aug 20, 2020
@metalmatze metalmatze deleted the ruler-dashboard-evaluations branch August 20, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants