querier: Dedup series is now replica label agnostic and simpler. Fixed panic seen when using larger number of replicas and small series. #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
issue-range-2645
branch
from
9d048e4
to
819b1a7
Compare
pkg/query/querier.go
Outdated
| // trimReplicaLabels removed replica labels from all series and re-sorts the set so that the same series are coming right after each other. | ||
| func trimReplicaLabels(set []storepb.Series, replicaLabels map[string]struct{}) { | ||
| for si := range set { | ||
| lset := set[si].Labels |
There was a problem hiding this comment.
Can we name the lset to labelSet? Sounds more intuitive
There was a problem hiding this comment.
I would stick to lset I know it might be confusing at the beginning but we are using this name everywhere in Thanos, Prometheus and Cortex. Plus we use lset ONLY for label sets (: So with this after learning that lset might make sense, what do you think? (:
There was a problem hiding this comment.
Sure, makes sense to follow the convention 😁
|
It should be good to review, just some tests I need to fix: |
bwplotka
force-pushed
the
issue-range-2645
branch
from
819b1a7
to
3daea58
Compare
|
Should be good to go now. |
bwplotka
force-pushed
the
issue-range-2645
branch
from
3daea58
to
3b248f0
Compare
…d panic seen when using larger number of replicas and small series. Fixes #2645 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
issue-range-2645
branch
from
3b248f0
to
5da2efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2645
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com