compact/tools: add hidden option for retrying downloads #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain environments, especially private, on-premise clouds, sometimes transient errors can happen due to misconfiguration or some reason. In my case, the S3 end-point sometimes had spuriously reset the TCP connection. Without functionality like this, it was almost impossible for Thanos Compact to finish its work considering sometimes we have to download hundreds of gigabytes of files. Curiously enough, only the downloading path was affected so this only adds retries for that direction. Opening this up without any tests to see if it is something we want to add to Thanos or we should implement thanos-io#2784? Or maybe both? Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
bwplotka
reviewed
Jul 23, 2020
There was a problem hiding this comment.
cc @kakkoyun
I think we have similar questions with Kemal, with where to put timeouts. Let's bring this in next Thanos community meeting? Also it would nice to talk about some ideas and tradeoffs here, maybe in some issue 🤔
WDYT?
| @@ -499,6 +500,9 @@ func (cc *compactConfig) registerFlag(cmd *kingpin.CmdClause) *compactConfig { | |||
| "This works well for deduplication of blocks with **precisely the same samples** like produced by Receiver replication."). | |||
| Hidden().StringsVar(&cc.dedupReplicaLabels) | |||
|
|
|||
| cmd.Flag("download.retries", "How many time to retry downloading a block with exponential backoff before giving up"). | |||
There was a problem hiding this comment.
hm again, this is similar to the #2908 discussion. Shouldn't this be applied by upload/download client itself?
2 tasks
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
😢 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments, especially private, on-premise clouds,
sometimes transient errors can happen due to misconfiguration or some
reason. In my case, the S3 end-point sometimes had spuriously reset the TCP
connection. Without functionality like this, it was almost impossible
for Thanos Compact to finish its work considering sometimes we have to
download hundreds of gigabytes of files.
Curiously enough, only the downloading path was affected so this only
adds retries for that direction.
Opening this up without any tests to see if it is something we want to
add to Thanos or we should implement
#2784? Or maybe both?
Signed-off-by: Giedrius Statkevičius giedriuswork@gmail.com
Changes
Added exponential backoff with a configurable amount of retries to
block.DownloadVerification
N/A for now