Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control response cache behavior based on query request #3109

Merged
merged 1 commit into from Sep 2, 2020
Merged

Control response cache behavior based on query request #3109

merged 1 commit into from Sep 2, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 1, 2020

Signed-off-by: Ben Ye yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  1. Update Cortex to master cortexproject/cortex@255ff33
  2. Add shouldCache function to check whether go to cache or not. If a request has store matches, then we shouldn't get results from cache.
  3. We can also control cache behavior based on the cache control header.

One thing to note is that in cortexproject/cortex#3051, Cortex uses a third-party fork for gomemcache.

Verification

Unit test added.

@yeya24
Control response cache behavoir
ae0f09f 
Signed-off-by: Ben Ye <yb532204897@gmail.com>
povilasv
povilasv approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but we have a failing CI

kakkoyun
kakkoyun approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kakkoyun kakkoyun merged commit 3ce1da8 into thanos-io:master Sep 2, 2020
@yeya24 yeya24 deleted the decide-cache-or-not branch September 2, 2020 15:01
@douglascamata douglascamata mentioned this pull request May 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@povilasv povilasv povilasv approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeya24 @kakkoyun @povilasv