Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify new bucket store metrics #3229

Merged
merged 2 commits into from Sep 30, 2020
Merged

Clarify new bucket store metrics #3229

merged 2 commits into from Sep 30, 2020

Conversation

pracucci
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

I found the description of the new metrics in the bucket store a bit difficult to understand. Does this change help to clarify it in your opinion?

Verification

N/A

@pracucci
Clarify new bucket store metrics
5b961a5 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
yeya24
yeya24 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

onprem
onprem approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits (powered by Grammarly™) :)

pkg/store/bucket.go Outdated Show resolved Hide resolved
pkg/store/bucket.go Outdated Show resolved Hide resolved
@pracucci
Improved metrics help message based on feedback received
bb9a338 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Copy link
Contributor Author

Thanks @prmsrswt for your review. I've applied your suggestions.

bwplotka
bwplotka approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@bwplotka bwplotka merged commit e4941a5 into thanos-io:master Sep 30, 2020
@pracucci pracucci deleted the clarify-new-bucket-store-metrics branch September 30, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@yeya24 yeya24 yeya24 approved these changes

@onprem onprem onprem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pracucci @bwplotka @yeya24 @onprem