labelbp: Renamed Label->Zlabel, and FullCopyLabel -> Label. #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
changed the title
No logic changed. Also commented the caution. ZLabel vs Label: ``` /tmp/___BenchmarkZLabelsMarshalUnmarshal_in_github_com_thanos_io_thanos_pkg_store_labelpb -test.v -test.bench ^\QBenchmarkZLabelsMarshalUnmarshal\E$ -test.run ^$ goos: linux goarch: amd64 pkg: github.com/thanos-io/thanos/pkg/store/labelpb BenchmarkZLabelsMarshalUnmarshal BenchmarkZLabelsMarshalUnmarshal/Label BenchmarkZLabelsMarshalUnmarshal/Label-12 8 133253790 ns/op 212008374 B/op 1000005 allocs/op BenchmarkZLabelsMarshalUnmarshal/ZLabel BenchmarkZLabelsMarshalUnmarshal/ZLabel-12 9 121597711 ns/op 100008368 B/op 5 allocs/op PASS Process finished with exit code 0 ``` Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
rename-zlabels
branch
from
21a3ef1
to
dbaefa6
Compare
yeya24
reviewed
Nov 19, 2020
| string Error = 4 [(gogoproto.jsontag) = "error,omitempty"]; | ||
| string Status = 1 [(gogoproto.jsontag) = "status"]; | ||
| // TODO(bwplotka): Experiment with ZLabelSet here. | ||
| repeated thanos.LabelSet Data = 2 [(gogoproto.nullable) = false, (gogoproto.jsontag) = "data"]; |
There was a problem hiding this comment.
This change from FullCopyLabelSet to thanos.LabelSet causes the bug of #3465, which returns nil when unmarshalling responses here.
However, another pr fixes this by changing thanos.LabelSet to thanos.ZLabelSet, @bwplotka any idea why LabelSet has problem unmarshalling while ZLabelSet doesn't have this problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logic changed. Also commented the caution.
Split of #3279
ZLabel vs Label: