Add a flag to disable step alignment middleware #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the E2E test failure is not related to this pr. But I am curious, can some maintainer help me re-trigger the GH CI? |
bwplotka
approved these changes
Oct 26, 2020
cmd/thanos/query_frontend.go
Outdated
| @@ -57,6 +57,9 @@ func registerQueryFrontend(app *extkingpin.App) { | |||
| cfg.http.registerFlag(cmd) | |||
|
|
|||
| // Query range tripperware flags. | |||
| cmd.Flag("query-range.align-querier-with-step", "Mutate incoming queries to align their start and end with their step."). | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flag("query-range.align-querier-with-step", "Mutate incoming queries to align their start and end with their step."). | |
| cmd.Flag("query-range.align-range-with-step", "Mutate incoming queries to align their start and end with their step for better cache-ability. Note: Grafana dashboards do that by default.") |
pkg/queryfrontend/config.go
Outdated
| @@ -139,6 +139,7 @@ type QueryRangeConfig struct { | |||
| ResultsCacheConfig *queryrange.ResultsCacheConfig | |||
| CachePathOrContent extflag.PathOrContent | |||
|
|
|||
| AlignQueriesWithStep bool | |||
There was a problem hiding this comment.
Suggested change
| AlignQueriesWithStep bool | |
| AlignRangeWithStep bool |
|
Done. PTAL again @bwplotka |
Signed-off-by: Ben Ye <yb532204897@gmail.com>
Signed-off-by: Ben Ye <yb532204897@gmail.com>
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* add a flag to disable step alignment middleware Signed-off-by: Ben Ye <yb532204897@gmail.com> * add changelog Signed-off-by: Ben Ye <yb532204897@gmail.com> * add logic Signed-off-by: Ben Ye <yb532204897@gmail.com> * fix lint Signed-off-by: Ben Ye <yb532204897@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye yb532204897@gmail.com
Changes
Fix #3353
Verification