rule: add --query.http-method #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
rule_add_post
branch
from
c630fc6
to
666f0eb
Compare
Add a new parameter which let's you specify what kind of HTTP method to use when sending queries. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
GiedriusS
force-pushed
the
rule_add_post
branch
from
666f0eb
to
fc8829c
Compare
bwplotka
approved these changes
Oct 30, 2020
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| - [#3346](https://github.com/thanos-io/thanos/pull/3346) Ruler UI: Fix a bug preventing the /rules endpoint from loading. | |||
| - [#3115](https://github.com/thanos-io/thanos/pull/3115) compact: now deletes partially uploaded and blocks with deletion marks concurrently. It does that at the beginning and then every `--compact.cleanup-interval` time period. By default it is 5 minutes. | |||
| - [#3312](https://github.com/thanos-io/thanos/pull/3312) s3: add list_objects_version config option for compatibility. | |||
| - [#3378](https://github.com/thanos-io/thanos/pull/3378) Ruler: learned to send queries via POST. Helps when alerting/recording rules are extra long. It now uses POST unless `--query.http-method` is `GET`. | |||
There was a problem hiding this comment.
learned? ;p Can we use more technical language?
There was a problem hiding this comment.
😄 reworked this line to make it more technical and even cleaner. Let me know if that works :P
Make it more technical :-P Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
bwplotka
approved these changes
Oct 30, 2020
|
Thanks! |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* rule: add --query.http-method Add a new parameter which let's you specify what kind of HTTP method to use when sending queries. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> * CHANGELOG: rework the line Make it more technical :-P Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter which lets you specify what kind of HTTP method to
use when sending queries.
Switch to using POST by default to avoid possible problems and because it
has been around for quite a while by now.
Signed-off-by: Giedrius Statkevičius giedriuswork@gmail.com
Verification
Tests still pass.
Closes #2577.
Closes #3233.