New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Added thanos bucket tool mark #3415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good!
This PR is still blocked on #3410 |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
88f0c6b
to
2ad1048
Compare
All fixed, should be good to go. |
Can u please fix the building error? Then it is good to go 🥇 |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* tools: Added thanos bucket tool mark Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Rebase. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fixed build errors. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com