Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Added thanos bucket tool mark #3415

Merged
merged 3 commits into from Nov 12, 2020
Merged

tools: Added thanos bucket tool mark #3415

merged 3 commits into from Nov 12, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 5, 2020

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

cmd/thanos/tools_bucket.go Show resolved Hide resolved
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

cmd/thanos/tools_bucket.go Show resolved Hide resolved
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

This PR is still blocked on #3410

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

All fixed, should be good to go.

@yeya24
Copy link
Contributor

yeya24 commented Nov 11, 2020

Can u please fix the building error? Then it is good to go 🥇

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka merged commit 69a045a into master Nov 12, 2020
@bwplotka bwplotka deleted the bucket-tool-mark branch November 12, 2020 14:59
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
* tools: Added thanos bucket tool mark

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Rebase.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Fixed build errors.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants