store: Enabled postings compressions by default. Removed feature flag. #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think we need special rc.1 just for it TBH @metalmatze |
bwplotka
force-pushed
the
post-compre
branch
from
27d03e7
to
212ba22
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
post-compre
branch
from
212ba22
to
4172a88
Compare
yeya24
approved these changes
Nov 16, 2020
|
LGTM as well. We're running it since its inception and haven't got any issue. |
metalmatze
pushed a commit
to metalmatze/thanos
that referenced
this pull request
Nov 20, 2020
thanos-io#3452) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
metalmatze
added a commit
to metalmatze/thanos
that referenced
this pull request
Nov 20, 2020
thanos-io#3452) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
metalmatze
added a commit
to metalmatze/thanos
that referenced
this pull request
Nov 20, 2020
thanos-io#3452) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
bwplotka
pushed a commit
that referenced
this pull request
Nov 20, 2020
* Prepare the v0.17.0-rc.0 release (#3441) Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * store: Enabled postings compressions by default. Removed feature flag. (#3452) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Publish v0.17.0 release (#3462) Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Set VERSION to 0.18.0-dev Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Fix changelog Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Fix bucket_test.go after rebase Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* Prepare the v0.17.0-rc.0 release (thanos-io#3441) Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * store: Enabled postings compressions by default. Removed feature flag. (thanos-io#3452) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Publish v0.17.0 release (thanos-io#3462) Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Set VERSION to 0.18.0-dev Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Fix changelog Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * Fix bucket_test.go after rebase Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As disscussed: https://cloud-native.slack.com/archives/CL25937SP/p1605529810257900
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com