Apply once when WatchInterval == 0 #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
zsuzhengdu
force-pushed
the
f/Added-flag-one-off-to-run-process-once-instead-of-watching
branch
from
b3a3939
to
fe63040
Compare
bwplotka
reviewed
Apr 1, 2021
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
zsuzhengdu
force-pushed
the
f/Added-flag-one-off-to-run-process-once-instead-of-watching
branch
from
0fe6904
to
29e2804
Compare
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
zsuzhengdu
force-pushed
the
f/Added-flag-one-off-to-run-process-once-instead-of-watching
branch
from
3b82659
to
5a4a378
Compare
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
zsuzhengdu
force-pushed
the
f/Added-flag-one-off-to-run-process-once-instead-of-watching
branch
from
a648cac
to
463f9dd
Compare
Signed-off-by: Du Zheng <zsuzhengdu@gmail.com>
zsuzhengdu
force-pushed
the
f/Added-flag-one-off-to-run-process-once-instead-of-watching
branch
from
7169f2b
to
bff5822
Compare
zsuzhengdu
changed the title
|
@bwplotka Would you please help to give another review on this PR? Thanks! |
bwplotka
reviewed
Apr 6, 2021
bwplotka
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix prometheus-operator/prometheus-operator#3061 (comment)
Verification
Manually tested. Working on unit tests.