Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin: Remove dependency on the rule dashboard from compact dashboard #4029

Merged
merged 1 commit into from Apr 8, 2021
+11 −10
Merged

Mixin: Remove dependency on the rule dashboard from compact dashboard #4029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@ We use _breaking :warning:_ to mark changes that are not backward compatible (re

## Unreleased

- [#4029](https://github.com/thanos-io/thanos/pull/4029) Mixin: Remove dependency on the rule dashboard when generating the compact dashboard
- [#4019](https://github.com/thanos-io/thanos/pull/4019) Query: Adds query range histogram.
- [#3350](https://github.com/thanos-io/thanos/pull/3350) Query/Sidecar: Added targets API support. You can now configure you Querier to fetch Prometheus targets from leaf Prometheus-es!

Expand Down
20 changes: 10 additions & 10 deletions mixin/dashboards/compact.libsonnet
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_group_compactions_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_group_compactions_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
)
Expand All @@ -57,7 +57,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_downsample_failed_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_downsample_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
)
Expand All @@ -79,12 +79,12 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_garbage_collection_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_compact_garbage_collection_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute garbage collection in quantiles.') +
g.latencyPanel('thanos_compact_garbage_collection_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_compact_garbage_collection_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
Expand Down Expand Up @@ -139,12 +139,12 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_blocks_meta_sync_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_blocks_meta_syncs_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute meta file sync, in quantiles.') +
g.latencyPanel('thanos_blocks_meta_sync_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_blocks_meta_sync_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
Expand All @@ -162,16 +162,16 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_objstore_bucket_operation_failures_total{%(selector)s}' % thanos.compact.dashboard.selector,
'thanos_objstore_bucket_operations_total{%(selector)s}' % thanos.compact.dashboard.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
)
)
.addPanel(
g.panel('Duration', 'Shows how long has it taken to execute operations against the bucket, in quantiles.') +
g.latencyPanel('thanos_objstore_bucket_operation_duration_seconds', thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.latencyPanel('thanos_objstore_bucket_operation_duration_seconds', thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
)
)
.addRow(
g.resourceUtilizationRow(thanos.rule.dashboard.selector, thanos.rule.dashboard.dimensions)
g.resourceUtilizationRow(thanos.compact.dashboard.selector, thanos.compact.dashboard.dimensions)
),

__overviewRows__+:: [
Expand All @@ -196,7 +196,7 @@ local utils = import '../lib/utils.libsonnet';
g.qpsErrTotalPanel(
'thanos_compact_group_compactions_failures_total{%(selector)s}' % thanos.dashboard.overview.selector,
'thanos_compact_group_compactions_total{%(selector)s}' % thanos.dashboard.overview.selector,
thanos.rule.dashboard.dimensions
thanos.compact.dashboard.dimensions
) +
g.addDashboardLink(thanos.compact.title)
) +
Expand Down