Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Katacoda multi-tenant tutorial #4318

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

bill3tt
Copy link
Contributor

@bill3tt bill3tt commented Jun 7, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #4309:

  • Updates prom-label-proxy image tag.
  • Updates links to Querier UIs.
  • Adds UI resources to unsafe-passthrough-paths.

Verification

Verified tutorial works in my personal katacoda account here per the documentation here

-non-api-path-passthrough \
-enable-label-apis && echo "Started prom-label-proxy"
-enable-label-apis \
-unsafe-passthrough-paths=/api/v1/stores,/api/v1/status/flags,/graph,/status,/api/v1/status/buildinfo,/api/v1/status/runtimeinfo,/flags,/static/css/2.a92efa4c.chunk.css,/static/css/main.e1aaea6d.chunk.css,/static/js/2.2de83b5e.chunk.js,/static/js/main.a767bdbf.chunk.js,/manifest.json && echo "Started prom-label-proxy"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bill3tt bill3tt force-pushed the fix-multi-tenant-tutorial branch 2 times, most recently from 91f267d to ce768ba Compare June 10, 2021 11:08
Signed-off-by: Ian Billett <ibillett@redhat.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🤩 LGTM 🚀

@kakkoyun kakkoyun merged commit 4c360e9 into thanos-io:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thanos katacoda course: Error fetching stores/flags list in Thanos UI
2 participants