Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestID for Deletion Requests #4454

Merged
merged 1 commit into from Jul 27, 2021

Conversation

ilangofman
Copy link
Contributor

@ilangofman ilangofman commented Jul 19, 2021

Signed-off-by: ilangofman igofman99@gmail.com

Hello, I mentioned this briefly in one of the community calls. Currently I am working on the adding the series deletion API in Cortex. To accomplish the task of permanently deleting the series, I would like to leverage the logic of the bucket rewrite work done inside of Thanos. To track which blocks have been rewritten, the proposed idea was to store the deletion request id inside of the meta.json file. Since the file is written from within Thanos, this PR will allow us to do this.

If anyone is intrested, the proposal for the API in Cortex can be found here.

Please let me know if there is any questions or concerns with this change.

Thanks

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Add a new variable inside the deletion request struct to store the deletion request id (could be empty).

Verification

Signed-off-by: ilangofman <igofman99@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry for lag in review.

@bwplotka bwplotka merged commit 83419bc into thanos-io:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants