Add RequestID for Deletion Requests #4454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ilangofman igofman99@gmail.com
Hello, I mentioned this briefly in one of the community calls. Currently I am working on the adding the series deletion API in Cortex. To accomplish the task of permanently deleting the series, I would like to leverage the logic of the bucket rewrite work done inside of Thanos. To track which blocks have been rewritten, the proposed idea was to store the deletion request id inside of the
meta.json
file. Since the file is written from within Thanos, this PR will allow us to do this.If anyone is intrested, the proposal for the API in Cortex can be found here.
Please let me know if there is any questions or concerns with this change.
Thanks
Changes
Verification