Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: fixed "all job" selector in thanos mixin dashboards #4532

Merged
merged 3 commits into from Aug 26, 2021

Conversation

ethernoy
Copy link
Contributor

@ethernoy ethernoy commented Aug 7, 2021

Signed-off-by: Ethern Su ehaprime@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Updated job selector in the following mixin dashboards to support "all" variable in Grafana for fixing #4488 :

  • bucket_replicate
  • compact
  • receive
  • rule
  • sidecar
  • store

Verification

Rendered the dashboard in jsonnet format to json, then imported to Grafana 8.0 in my local microK8s cluster for testing.

@ethernoy ethernoy changed the title mixin: fixed dashboard "all" selector not working issue mixin: fixed "all job" selector in thanos mixin dashboards Aug 7, 2021
@ethernoy ethernoy marked this pull request as ready for review August 7, 2021 14:36
Signed-off-by: Ethern Su <ehaprime@gmail.com>
@ethernoy ethernoy force-pushed the feature/fix-dashboard-all-selector branch from 860a92d to 0951155 Compare August 8, 2021 07:06
@ethernoy
Copy link
Contributor Author

@wiardvanrij Hi, seems the PR is blocked by test case unrelated to my code change. Do you have any hint on solving this?

@wiardvanrij
Copy link
Member

@ethernoy - Try to restart the testing by doing an empty commit:

git commit --allow-empty -s -m 'e2e retest'

I'm somewhat sure you hit a flaky test :x

Signed-off-by: Ethern Su <ehaprime@gmail.com>
@ethernoy
Copy link
Contributor Author

@ethernoy - Try to restart the testing by doing an empty commit:

git commit --allow-empty -s -m 'e2e retest'

I'm somewhat sure you hit a flaky test :x

Thank you! You are right, it was indeed a flaky test :)

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@kakkoyun kakkoyun merged commit 2e370d5 into thanos-io:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants