ui: Add filter compaction UI #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice! But why the page title is |
This is a side effect of how we choose to do development locally. The UI in dev mode just assumes that it is running for Querier. |
|
This looks good. @adzshaf Can you please resolve the conflict? |
|
Any other work needs to be done for this pr? @onprem If not I am happy to resolve the conflicts and get this feature merged. |
onprem
previously approved these changes
Nov 2, 2021
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
add-filter-compaction
branch
from
e4ad05e
to
8ef1422
Compare
yeya24
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is part of LFX Mentorship project to improve Block Viewer UI (issue: #3112). We want to add feature so user can filter blocks by compaction level.
Verification
When we haven't filter anything yet:
Filter by compaction level:
Tested on local using
make quickstartcc: @onprem @squat