Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--bugfix:udate go.mod file with expired dependancy #4604

Merged

Conversation

hanyuancheung
Copy link
Contributor

Signed-off-by: zhyChesterCheung cheung.zhy.csu@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Resolved: #4603

Replace the expired go.mod dependency github.com/efficientgo/tools/e2e with the new one.

Verification

Looks good.

Signed-off-by: zhyChesterCheung <cheung.zhy.csu@gmail.com>
@bill3tt
Copy link
Contributor

bill3tt commented Aug 26, 2021

Hmm if this is indeed broken - I would wonder why this didn't fail out testing suite on master 🤔 Any thought @zhyChesterCheung ?

@hanyuancheung
Copy link
Contributor Author

Hmm if this is indeed broken - I would wonder why this didn't fail out testing suite on master 🤔 Any thought @zhyChesterCheung ?

Yeah, I think this is happening indeed with the environment: OSX 10.15.7 & Golang 1.16.3. Maybe it won't occur in master workflow environment, but we should update the dependency to improve the compatibility with more env. Thx

@bwplotka
Copy link
Member

Commented on the issue, I think the assumption is wrong, but this change will make sure we pin all in known working version, so we can merge it. I was changing efficientgo/tools,but not sure why unexsiting commit was chosen for you. Maybe it was pinned to PR that got removed? Not sure.

@bwplotka bwplotka enabled auto-merge (squash) August 27, 2021 13:43
@bwplotka bwplotka merged commit ba92c0c into thanos-io:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go get dependency failed because of expired go.mod file.
3 participants