Added more metadata to Series tracing; Improved tracing docs, tests; Added example. #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
tracing-test
branch
3 times, most recently
from
ac16cea
to
ab1d049
Compare
|
Somehow stats for series on block-level has to be fixed: Works on proxy level:
And on Prometheus level:
|
bwplotka
force-pushed
the
tracing-test
branch
2 times, most recently
from
4acc744
to
ad33670
Compare
|
Works now:
|
…Added example. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
tracing-test
branch
from
ad33670
to
add38df
Compare
GiedriusS
previously approved these changes
Sep 1, 2021
Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
onprem
previously approved these changes
Sep 1, 2021
Co-authored-by: Prem Kumar <prmsrswt@gmail.com>
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Nov 7, 2021
…Added example. (thanos-io#4619) * Added more metadata to Series tracing; Improved tracing docs, tests; Added example. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Update docs/tracing.md Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com> * Update docs/tracing.md Co-authored-by: Prem Kumar <prmsrswt@gmail.com> Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com> Co-authored-by: Prem Kumar <prmsrswt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com