Add capability to use custom AWS STS Endpoint #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomáš Novák <tom.nov96@gmail.com>
Signed-off-by: Tomáš Novák <tom.nov96@gmail.com>
bwplotka
previously approved these changes
Oct 18, 2021
|
|
||
| If you want to use IAM credential retrieved from an instance profile, Thanos needs to authenticate through AWS STS. For this purposes you can specify your own STS Endpoint. | ||
|
|
||
| By default Thanos will use endpoint: https://sts.amazonaws.com and AWS region coresponding endpoints. |
| @@ -228,6 +229,7 @@ func NewBucketWithConfig(logger log.Logger, config Config, component string) (*B | |||
| Client: &http.Client{ | |||
| Transport: http.DefaultTransport, | |||
| }, | |||
| Endpoint: config.STSEndpoint, | |||
|
Looks like we might have unformatted code? Feel free to run |
|
And ping us on #thanos-dev, sad that first contributor CI pipelines has to enabled manually ): |
Signed-off-by: Tomáš Novák <tom.nov96@gmail.com>
|
Yeah, there was problem with formatting. I forgotten run thanos/pkg/compact/downsample/downsample.go Line 236 in 48a068c But I do not interfered to this code. |
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Tomáš Novák <tom.nov96@gmail.com>
|
Commited suggestion. Now should CI pass and PR will be ready to final review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added capability to use custom AWS STS Endpoint. It is helpfull when you cannot communicate out of AWS network to default endpoint https://sts.amazonaws.com/
If parameter
sts_endpointwill not be set, minio used default https://sts.amazonaws.com/ or another regional mutation of this endpoint. Look hereVerification
I cannot run test along our testing buckets, then I test only
make test-localandmake test-e2e-local. I will be happy when someone else try it on real bucket.Review
This is my first public PR ever, then can I ask you (as maintainer of AWS/S3 client) to review this PR @bwplotka?